fix(examples): front-end packages missing browserify polyfills #1224 #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edger-cacti#1224 The webpack build done by the Angular CLI (ng) was broken due to a few different issues combined together: 1. After upgrading to Angular v12 IE 11 is no longer supported which necessitated the explicit configuration in the browserlist rc config file accordingly so that the compilation process does not try to support a browser for which the build is broken to begin with. 2. polyfills had to be added via customizing the webpack configuration used by the Angular CLI internally which is now being done by using a custom builder as specified in the angular.json file. This is the new method of dealing with these kind of issues after the ng eject command was deprecated a while back. The webpack.config.overrides.js files that are beind added in this commit contain only the overrides (as the name suggests) not the entire webpack configuration that the Angular CLI uses internally to build the front end packages. Fixes hyperledger-cacti#1224 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 71.95% 71.95%
=======================================
Files 270 270
Lines 9438 9438
Branches 1112 1112
=======================================
Hits 6791 6791
Misses 2075 2075
Partials 572 572 Continue to review full report at Codecov.
|
takeutak
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webpack build done by the Angular CLI (ng) was broken due to a few
different issues combined together:
necessitated the explicit configuration in the browserlist rc config
file accordingly so that the compilation process does not try to support
a browser for which the build is broken to begin with.
used by the Angular CLI internally which is now being done by using a
custom builder as specified in the angular.json file. This is the new
method of dealing with these kind of issues after the ng eject command
was deprecated a while back. The webpack.config.overrides.js files
that are beind added in this commit contain only the overrides (as the
name suggests) not the entire webpack configuration that the Angular
CLI uses internally to build the front end packages.
Fixes #1224
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com